Don't shut down unresponsive workers on gather()#8101
Merged
Conversation
crusaderky
force-pushed
the
gather_closes_workers
branch
from
fe4341d to
b68af81
Compare
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 20 files ± 0 20 suites ±0 12h 8m 34s ⏱️ + 1h 51m 7s For more details on these failures, see this check. Results for commit b68af81. ± Comparison against base commit b3dde5c. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both. |
Collaborator
Author
|
All failures seem unreleated; ready for review and merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR plugs the last known case (to me at least) where a GIL blockage will cause computations to fail and workers to be shut down. Happy to hear if there are any more.
CC @fjetter @hendrikmakait